Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(client): PGlite driver and example #1058

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

samwillis
Copy link
Contributor

@samwillis samwillis commented Mar 14, 2024

Currently blocked on Postgres client support #1038

Builds on parameterized query support for PGlite: electric-sql/pglite#39

@kevin-dp kevin-dp force-pushed the kevindp/vax-1638-pg-generator branch from 9987b45 to 21d114b Compare March 14, 2024 13:39
@samwillis samwillis force-pushed the samwillis/pglite branch 2 times, most recently from 2c8f96b to 7840f4f Compare March 18, 2024 14:00
@AntonOfTheWoods
Copy link
Contributor

@samwillis , is moving forward on this just blocked by #1038 ?

@samwillis
Copy link
Contributor Author

@AntonOfTheWoods yes, however @kevin-dp is actively working on it. Will be ready very soon, my guess would be a couple of weeks to get PGlite support out (I'm off this coming week)

@AntonOfTheWoods
Copy link
Contributor

Thanks @samwillis . I'm working on getting a full react-admin + supabase + electric PWA example done with all the supabase features in a Kubernetes helm chart, and wanted to skip SQLite if possible!

@kevin-dp kevin-dp force-pushed the kevindp/vax-1638-pg-generator branch 2 times, most recently from 570b24f to 37bb5b9 Compare April 8, 2024 13:58
@msfstef msfstef force-pushed the kevindp/vax-1638-pg-generator branch from 37bb5b9 to 95f3314 Compare April 9, 2024 08:05
@kevin-dp kevin-dp force-pushed the kevindp/vax-1638-pg-generator branch from 58751d8 to c6f3823 Compare April 16, 2024 13:36
@samwillis samwillis force-pushed the samwillis/pglite branch 2 times, most recently from e54b3cb to 81c0732 Compare April 16, 2024 18:40
@samwillis samwillis changed the title WIP feature(client): PGlite driver and example feature(client): PGlite driver and example Apr 16, 2024
@samwillis samwillis marked this pull request as ready for review April 16, 2024 18:41
@samwillis samwillis requested review from msfstef and kevin-dp and removed request for msfstef April 16, 2024 18:46
@samwillis
Copy link
Contributor Author

@msfstef I think you made some changes to the examples to unify their structure, could you take a look at this one and see if anything needs changing as I forked it from the web-wa-sqlite example before your changes.

@msfstef
Copy link
Contributor

msfstef commented Apr 17, 2024

@samwillis I've pushed the minor changes - basically I split out the electric provider where we initialize the db and client and the actual example with the items.

Also in the web examples I've removed the mention of how to check out the example from the monorepo in the README in order to use them as they are for the create-electric-app tool as they are (can't use an "overlay" since React Native and Expo have significantly different instructions), but we can discuss those details separately when/if we decide to use pglite as our web starter instead of wa-sqlite. I haven't replicated the README change here.

clients/typescript/src/drivers/pglite/database.ts Outdated Show resolved Hide resolved
examples/web-pglite/.env Show resolved Hide resolved
examples/web-pglite/package.json Outdated Show resolved Hide resolved
examples/web-pglite/README.md Show resolved Hide resolved
Copy link
Contributor

@kevin-dp kevin-dp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Left some minor comments but nothing blocking

clients/typescript/package.json Outdated Show resolved Hide resolved
clients/typescript/package.json Outdated Show resolved Hide resolved
clients/typescript/src/drivers/pglite/adapter.ts Outdated Show resolved Hide resolved
clients/typescript/src/drivers/pglite/database.ts Outdated Show resolved Hide resolved
clients/typescript/src/drivers/pglite/database.ts Outdated Show resolved Hide resolved
@kevin-dp kevin-dp merged commit 89bff9b into kevindp/vax-1638-pg-generator Apr 18, 2024
7 of 14 checks passed
@kevin-dp kevin-dp deleted the samwillis/pglite branch April 18, 2024 13:49
kevin-dp pushed a commit that referenced this pull request Apr 22, 2024
PGlite driver for Electric

Builds on parameterized query support for PGlite:
electric-sql/pglite#39

---------

Co-authored-by: msfstef <msfstef@gmail.com>
kevin-dp pushed a commit that referenced this pull request Apr 23, 2024
PGlite driver for Electric

Builds on parameterized query support for PGlite:
electric-sql/pglite#39

---------

Co-authored-by: msfstef <msfstef@gmail.com>
kevin-dp pushed a commit that referenced this pull request Apr 25, 2024
PGlite driver for Electric

Builds on parameterized query support for PGlite:
electric-sql/pglite#39

---------

Co-authored-by: msfstef <msfstef@gmail.com>
kevin-dp pushed a commit that referenced this pull request Apr 29, 2024
PGlite driver for Electric

Builds on parameterized query support for PGlite:
electric-sql/pglite#39

---------

Co-authored-by: msfstef <msfstef@gmail.com>
kevin-dp pushed a commit that referenced this pull request Apr 30, 2024
PGlite driver for Electric

Builds on parameterized query support for PGlite:
electric-sql/pglite#39

---------

Co-authored-by: msfstef <msfstef@gmail.com>
kevin-dp pushed a commit that referenced this pull request Apr 30, 2024
PGlite driver for Electric

Builds on parameterized query support for PGlite:
electric-sql/pglite#39

---------

Co-authored-by: msfstef <msfstef@gmail.com>
kevin-dp pushed a commit that referenced this pull request Apr 30, 2024
PGlite driver for Electric

Builds on parameterized query support for PGlite:
electric-sql/pglite#39

---------

Co-authored-by: msfstef <msfstef@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants